lkml icon indicating copy to clipboard operation
lkml copied to clipboard

Field filters on a dimension called `action` triggers pluralize

Open owlas opened this issue 1 year ago • 0 comments

There is handling for special keywords in this file: https://github.com/joshtemple/lkml/blob/9fc81c0fd5abb504a7b15643cbd056745e1e020c/lkml/keys.py#L15

Including action

The problem is that if I have a filter on a dimension called action it doesn't correctly parse

lkml

measure broken {
  type: count
  filters: {
    name: oliver
    action: click
  }
}

parsed object

Leads to this value for filters__all

# actual
[{'name': 'oliver'}, {'actions': ['click'']}]

# should be
[{'name': 'oliver'}, {'action': 'click'}]

^ action becomes actions and the filter values go into an array

owlas avatar Nov 25 '24 15:11 owlas