lkml

lkml copied to clipboard

lkml.dump deletes "name" key from dict

4

[dump](https://github.com/joshtemple/lkml/blob/3d629172bbc97a93f1d5f5af0cf4f219752a1ca8/lkml/__init__.py#L56) function mutates input dict by removing all "name" fields in the dict. Looks like it is caused by a `.pop` call on [this line](https://github.com/joshtemple/lkml/blob/3d629172bbc97a93f1d5f5af0cf4f219752a1ca8/lkml/simple.py#L312).

victoryifei

Many of the docstrings in lkml are outdated, especially in `simple.DictParser`.

joshtemple

For a dimension definition: ``` { "name": "field_name", "sql": "${TABLE}.field_name ;;" } ``` When the lookml is generated, another `;;` is appended. I'm seeing two options (there's probably more): -...

fbertsch

It could be useful to have a line width option that, when supplied to the serializer, adds line breaks where needed to keep the maximum line width within a certain...

joshtemple

For ease of use in Python, `lkml` should convert values that are `yes` or `no` strings into `True` and `False` boolean values.

joshtemple

lkml only parses a single constant, even when multiple constants are defined

4

in this example model.lkml file: ``` connection: "my_connection" constant: my_constant { value: "my_value" } constant: other_constant { value: "other_value" } view: view_name { sql_table_name: my_schema.table_name ;; dimension: dimension_name { type:...

EyalDlph

lkml goes into infinite loop

4

when there is a single semi-colon (`;`) in the file, `lkml` goes into infinite loop. In `lexer.py`, `Lexer.scan()`, around line 78, is peeking ahead to look for double semi-columns (`;;`)....

EyalDlph

This should close https://github.com/joshtemple/lkml/issues/88. ``` > lkml --help usage: lkml [-h] [-v] [--json | --lookml | -w] file A blazing fast LookML parser, implemented in pure Python. When invoked from...

remisalmon

Add cli options to output lookml

2

Thanks for lkml, it would be great to have the option in the command line to output the parsed LookML in LookML format (in addition to JSON). Even better if...

remisalmon

Dynamically set SyntaxNode prefix and line number

2

Hi! First off thanks for all the work that went into this library, it has exactly what I was looking for! I'm creating a class which adds descriptions to dimensions...

Nhyland28