ethereum-abi-types-generator icon indicating copy to clipboard operation
ethereum-abi-types-generator copied to clipboard

missing property in ethers overrides - blockTag

Open TJakubek opened this issue 2 years ago • 3 comments

hey bud,

first off - big fan, great project.

Not 100% sure as I've yet to test it out but I think the type 'ContractCallOverrides' is missing a property for ethers_v5. According to documentation there should also be a property 'blockTag' in the overrides, which allows querying data from a specific block (if your endpoint allows it).

So for example querying a balance could look like this:

const balance = await token.balanceOf('0xSuperGreatAddress', { blockTag: 12345 })

TJakubek avatar Aug 11 '22 14:08 TJakubek

Nice! Think I need to upgrade to latest ethers as some other stuff is not pulled though in the typings.. FYI that call would work the typings are just missing I will sort thanks for raising

joshstevens19 avatar Aug 14 '22 11:08 joshstevens19

sure, have it working, just dont want to override types 😅 keep up the good work, I will keep an eye out for the update

TJakubek avatar Aug 15 '22 08:08 TJakubek

I hit this myself today will update the repo to fix this sorry for delay

joshstevens19 avatar Nov 23 '22 21:11 joshstevens19