ethereum-abi-types-generator icon indicating copy to clipboard operation
ethereum-abi-types-generator copied to clipboard

Use unique interface name for tuple requests

Open JSRossiter opened this issue 3 years ago • 5 comments

Currently if a function has multiple tuple parameters only one Request interface is generated and used for all of them.

I haven't tested this change, and not sure how deep tuples are handled but I think something like this should be useful.

JSRossiter avatar Jan 12 '22 21:01 JSRossiter

Hey sorry i missed this.. when would you have a tuple named the same name with different interface?

joshstevens19 avatar Feb 22 '22 10:02 joshstevens19

foo(tuple arg1, tuple arg2) currently creates one interface named FooRequest, after this change it should create FooArg1Request and FooArg2Request

JSRossiter avatar Feb 24 '22 21:02 JSRossiter

Ahhhh I get you have you got an example ABI I can use to do some testing that you have used to verify this change? If not no worries can gen one and test it out

joshstevens19 avatar Feb 24 '22 22:02 joshstevens19

I don't have one, sorry

JSRossiter avatar Feb 24 '22 22:02 JSRossiter

Scam Comment @joshstevens19

ramazansancar avatar Jan 24 '24 07:01 ramazansancar