ttrss-to-wallabag-v2 icon indicating copy to clipboard operation
ttrss-to-wallabag-v2 copied to clipboard

Can't save to Wallabag

Open Trottel opened this issue 3 years ago • 5 comments

After the last changes in TT RSS there is no Save to Wallabag buton nor the keyboard shortcut A+W works.

Trottel avatar Nov 23 '21 07:11 Trottel

the problem (well, there could be more, i haven't checked any further) is invalid markup in the article button hook handler:

@@ -164,7 +165,7 @@ class Wallabag_v2 extends Plugin {
                $rv = "<img id=\"wallabagImgId\" src=\"plugins.local/wallabag_v2/wallabag.png\"
                        class='tagsPic' style=\"cursor: pointer;\"
                        onclick=\"postArticleToWallabag($article_id)\"
-                       title='".__('Wallabag v2')."'>";
+                       title='".__('Wallabag v2')."'/>";

also, it looks like there's a typo which prevents this plugin from being user-loaded:

--- a/wallabag_v2/init.php
+++ b/wallabag_v2/init.php
@@ -6,6 +6,7 @@ class Wallabag_v2 extends Plugin {
                return array("2.0.0",
                        "Post articles to a Wallabag v 2.x instance",
                        "[email protected]",
+                       false,
                        "https://github.com/joshp23/ttrss-to-wallabag-v2");
        }

cthu1hoo avatar Jan 01 '22 08:01 cthu1hoo

Thank you very much @cthu1hoo , now it's working!

Trottel avatar Jan 01 '22 12:01 Trottel

if you could put in a pull request I'll be happy to merge it.

joshp23 avatar Jan 01 '22 18:01 joshp23

I made a pull reguest :)

Trottel avatar Jan 01 '22 20:01 Trottel

@cthu1hoo thx a lot!!

Nikkiiw avatar Apr 17 '22 17:04 Nikkiiw