etch icon indicating copy to clipboard operation
etch copied to clipboard

Change data-button-class seems not working in FF & IE

Open PierreLeresteux opened this issue 12 years ago • 2 comments

In your demo on http://etchjs.com/ the button layout changes at well when you change between title and body. But in your tryit.html, if you had a title, the button layout doesn't change.

Without removing the editor, the button layout doesn't change.

My first investigation is that the version of backbonejs uses between the demos are not the same and "maybe" in the editableInit this code doesn't copy/paste the editorModel.attributes.buttons[]

editorModel.set({
     editable: $editable,
     editableModel: this.model
});

This problem doesn't appear in Chrome but always in FF and IE.

PierreLeresteux avatar Jul 04 '12 13:07 PierreLeresteux

I'm not able to reproduce this in FF 14 or 15. What version are you using?

joshontheweb avatar Sep 06 '12 01:09 joshontheweb

Hi Josh,

I've seen that you change your tryit.html to test this bug.

I reproduce the bug with this change (replace H1 by a DIV):

<div class="title editable">Here is a title</div>

instead of

 <h1 class="title editable">Here is a title</h1>

In this configuration, if you click on the text "Here is a title", you have a minimal etch (normal behavior). But if you click on the text below, etch stay in minimal state.

FYI : I'm using FF 14.0.1 in Fedora 16, but I reproduce this bug in IE9 - Windows 7 too (don't have my mac at work, so I can't test on OSX)

PierreLeresteux avatar Sep 06 '12 07:09 PierreLeresteux