node-pureimage icon indicating copy to clipboard operation
node-pureimage copied to clipboard

Published 20 hours ago • verified publisher icon joshmarinacci

Make JPEG quality configurable

Open andypotato opened this issue 6 years ago • 1 comments

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [X] My code follows the code style of this project.
  • [X] My change requires a change to the documentation.
  • [X] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

Description

This change adds a parameter for making the JPEG output quality configurable. The default of 50 is too low in many cases so I thought why not directly make it configurable.

Cheers

andypotato avatar Jun 10 '19 10:06 andypotato

Thank you for this PR @andypotato . Adding quality control is a good feature to have. However, with the way you've implemented this change the quality setting is required. Would it be possible to make it optional? If the developer doesn't pass in a quality setting then a default one would be supplied?

thanks!

joshmarinacci avatar Jun 14 '19 15:06 joshmarinacci