cpack lib package fix

[5shekel]

needs to adapt all install directive in cmakelist to added them to the package. otherwise it will generate an empty zip see https://cmake.org/pipermail/cmake/2012-October/052410.html

install(
  TARGETS ${libname} 
  LIBRARY DESTINATION lib COMPONENT ${PLUGIN_INSTALL_DIR}
  )

[joshdoe]

I tested on Ubuntu with master and it is an empty zip, with your PR it creates the correct zip. However, on Windows with or without your PR it creates an incomplete zip, only including the klv library. Let me try a few things.

[5shekel]

yes i should've mention i only tested on linux...

[joshdoe]

@5shekel can you test my cpack-0 branch? I added one more commit, which seems to work both on Windows and Linux. I changed the behavior of PLUGIN_INSTALL_DIR et. al., so now it's a relative path to CMAKE_INSTALL_PREFIX. Probably should change the name...

[5shekel]

its empty zip with your mods on WSL/ubuntu

[ahogen]

However, on Windows with or without your PR it creates an incomplete zip, only including the klv library. Let me try a few things.

I haven't read the full PR here, but skimming I see a lot of...

install(
  TARGETS ${libname} 
  LIBRARY DESTINATION lib COMPONENT ${PLUGIN_INSTALL_DIR}
)

Which is missing RUNTIME DESTINATION. Keep in mind Windows DLLs are runtime executable, unlike Linux shared objects. Maybe try...?

install(
  TARGETS ${libname} 
  RUNTIME DESTINATION lib COMPONENT ${PLUGIN_INSTALL_DIR}
  LIBRARY DESTINATION lib COMPONENT ${PLUGIN_INSTALL_DIR}
)

ref: https://cmake.org/cmake/help/latest/command/install.html#installing-targets