node-cognitive-services icon indicating copy to clipboard operation
node-cognitive-services copied to clipboard

Published 20 hours ago • verified publisher icon joshbalfour

Add Video Indexer v2

Open noce2 opened this issue 6 years ago • 5 comments

To ensure the getAccounts method of v2 of the video indexer api is working properly, I have written a unit test. As the video indexer has a large API, I wanted to do a small PR to check that my approach is correct before I plough ahead with the rest of the work.

noce2 avatar Nov 12 '18 02:11 noce2

Thanks @noce2! The 4 tests pass. Only nitpick is the missing catch in the beforeEach. Please fix that and I'll merge.

miparnisari avatar Jan 08 '19 04:01 miparnisari

@miparnisari @noce2 I was going to open a PR for this myself but this looks done. If I were to add the catch on the beforeEachwould this still be mergeable?

cornu-ammonis avatar Jun 02 '19 14:06 cornu-ammonis

Hi @miparnisari, can you close this open request? It would be great for me to continue. Moreover, I tried to look around any file/folder for indexer under vision folder. But I didn't find any.

vatsal2210 avatar Jun 05 '19 23:06 vatsal2210

@noce2 can you review my comment and fix the merge conflict?

miparnisari avatar Jun 06 '19 02:06 miparnisari

sure :)

noce2 avatar Jun 06 '19 06:06 noce2