Josh Bleecher Snyder

Results 320 comments of Josh Bleecher Snyder
trafficstars

Interesting idea. Although I think it’d be better to do that with a branch for now.

I believe the best fix here is to rewrite our coverage instruction to use cmd/internal/edit, at which point we can benefit from improvements made to cmd/cover. Related: https://github.com/golang/go/issues/29824. Ultimately it...

> Re cumbersome, do you mean the large code template embed in the code? Yes. > I am not too worried about strictly internal details that we are free to...

Discussion of how the json parser should handle particular inputs should probably happen in a new issue in the Go repo. (Sorry you keep getting bounced around.)

I didn't see a new issue get filed, so just in case, cc @mvdan, who probably has opinions about the json parser's behavior.

Thanks for digging. It must have changed during this cycle; it once worked. I guess we need to grab both stderr and stdout and combine them, so it works at...

Totally understood. Will put it in my queue.

Huh. OK, I'll take another look.

AFK but I think the bug here is actually the terrible error message ("exit status 2"). On a hunch, what is your git version? Might be old enough that 'git...

Yes, that should be fine. I'll have to go through and improve all error messages. If you are blocked on this and want to dig, next step is finding out...