Josh Bleecher Snyder

Results 372 comments of Josh Bleecher Snyder

I'm interested in doing this, but not using unsafe.

Some simple codegen could provide the flag and the list of benchmarks. The basic implementation of benchmarking is pretty simple and could be copy/pasted; CL 10020 makes it simpler yet....

@minux well, a combination of unsafe, reflection, and testing.M seemed like the best combination in the end. Please see [package benchserve](https://github.com/josharian/benchserve) ([godoc](https://godoc.org/github.com/josharian/benchserve)) for an initial implementation. Feedback most welcome. If...

I've updated [benchserve](https://godoc.org/github.com/josharian/benchserve) to support the case in which there is already a TestMain. I also added an (aspirational, unwritten) [client API](https://godoc.org/github.com/josharian/benchserve/benchcli) to make writing drivers easier.

@gaillard I think -benchsplit (#19128) will help on this front.

Does it? ```go package p import ( "testing" "time" ) func BenchmarkSleep(b *testing.B) { for dur := time.Microsecond; dur

I'd like this too. If I sent a PR adding this, would it get reviewed? I imagine it'd be pretty small.

It'd be nice to get this in, since current `main` doesn't build, due to submodule skew.

I just ran into this as well, porting some code from `string` to `[]rune`, which reinforces [Ian's point above](https://github.com/golang/go/issues/63128#issuecomment-1728281660).

My gut reaction is as follows. Happy to discuss more. > We might want to think a bit more carefully bout associative operators. Should prob be able to say things...