Josh Bleecher Snyder
Josh Bleecher Snyder
Test failure is due to a data race. Once #4584 goes in, the test will pass.
Unfortunately, GitHub tests the exact commit (which is unchanged after the merge), not "what would be in develop after merging". I'll rebase my commit and then the tests will pass.
Still failing. Neat. I’ll look later.
OK, the problem is confusion over who owns the objects slice. The code is inconsistent. In some places (e.g. Remove), it appears that the container maintains its own copy of...
> Regarding this, I think it makes more sense for the Container to "own" the Objects slice, and for the tests to be updated to reflect that. Ok, I will...
> we can document how users should safely access the field I looked at this a bit, and I would describe my current status as "mild despair". I don't think...
hello, @Xe! i just hit this too. possible dups: https://github.com/ollama/ollama/issues/2351 and https://github.com/ollama/ollama/issues/2577. I think the suggestion in https://github.com/ollama/ollama/issues/2577 is probably the cleanest fix: > [force the] message to terminate immediately...
It looks like this might be as simple as removing ` ws` from the end of: ``` object ::= "{" ws ( string ":" ws value ("," ws string ":"...
I'd prefer to remove `ws` from the grammar entirely. Why waste cycles on pretty-printing tokens? That can be using encoding/json afterwards, if we care. Another, perhaps better, approach to this...
Filed #2895 for BYO GBNF support.