josh icon indicating copy to clipboard operation
josh copied to clipboard

`get_version.t` fails if no tag is available

Open jsoref opened this issue 8 months ago • 0 comments

https://github.com/check-spelling-sandbox/josh-project-josh/actions/runs/14741794393/job/41381279387#step:7:301

proxy/get_version.t: failed
--- tests/proxy/get_version.t
+++ tests/proxy/get_version.t.err
@@ -2,7 +2,7 @@
   $ cd ${TESTTMP}
 
   $ curl -s http://localhost:8002/version
-  Version: *.*.* (glob)
+  Version: 3da0ae7
 
   $ bash ${TESTDIR}/destroy_test_env.sh
   .

The code is testing the /version endpoint...

https://github.com/josh-project/josh/blob/c778c0eda84e1e642e4c3e1b14afc46a12f3c213/josh-proxy/src/bin/josh-proxy.rs#L319-L321 https://github.com/josh-project/josh/blob/c778c0eda84e1e642e4c3e1b14afc46a12f3c213/josh-proxy/src/bin/josh-proxy.rs#L35-L36 https://github.com/josh-project/josh/blob/c778c0eda84e1e642e4c3e1b14afc46a12f3c213/josh-core/src/lib.rs#L81-L82 https://github.com/josh-project/josh/blob/c778c0eda84e1e642e4c3e1b14afc46a12f3c213/josh-core/src/lib.rs#L89-L93

There are a number of cases where the outcome will not match this pattern...

Certainly, anyone who forks this repository with github's defaults of only cloning the default branch won't have any tags. And if they enable actions and then pull in an updated master, their build would fail. (In my case, I forced the issue by pushing something else to master because I'm testing things, but the same would happen as outlined.)

jsoref avatar Apr 29 '25 22:04 jsoref