tab-stash icon indicating copy to clipboard operation
tab-stash copied to clipboard
verified publisher icon josh-berry

Toolbar button does not close sidebar when pressed a second time

Open acc987 opened this issue 4 years ago • 1 comments

System Details

  • OS Version: openSUSE Leap 15.3
  • Browser Version: Firefox 78.11.0esr
  • Tab Stash Version: 2.9

Describe the Bug

When the behavior of the toolbar button is set to show the stash in the sidebar, pressing it will open the sidebar displaying the Tab Stash but pressing the button again does not close the sidebar.

Expected Behavior

I expect that the sidebar closes when pressing the Tab Stash toolbar button if the Tab Stash is still being displayed in the sidebar. Naturally, if the sidebar is already open but the Tab Stash is not displayed, then pressing the Tab Stash toolbar button should still result in the Tab Stash being displayed in the sidebar.

(This is also the behavior when using dedicated sidebar button in the toolbar and even when opening the history or bookmark drop-down menu from the toolbar and selecting to show the history/bookmarks in the sidebar, the same entry will then change to hide the sidebar instead when the corresponding drop-down menu is reopened.)

Steps to Reproduce

  1. Make sure that the Tab Stash button is displayed in the toolbar and configured to open the Tab Stash in the sidebar.
  2. Press the Tab Stash button in the toolbar to open the sidebar. The sidebar opens and displays the Tab Stash.
  3. Press the Tab Stash toolbar button again. The sidebar remains open.

Off-topic praise

Since positive feedback would get lost otherwise: Aside from the issue mentioned above, I enjoy using your addon a lot. You have also given your addon a very clean and consistent user interface design and preferences page, which is very much appreciated!

Readers: If you are also experiencing this bug, please vote for it by giving the ORIGINAL POST a thumbs-up using the :smiley: button. You are welcome to leave comments and discuss the issue if you have more details to add, but "Me too!" comments are not counted by the voting system.

acc987 avatar Jun 17 '21 14:06 acc987

Makes sense, I'll keep this in mind for a future release!

And thanks, I'm glad to hear you're enjoying it! 😄

josh-berry avatar Jun 19 '21 16:06 josh-berry