José Valim
José Valim
The only thing holding this PR is to decide if we want to add a similar API to capture logs, such as: ```elixir @tag :capture_log test "foo", %{capture_log: log} do...
I think this reads well: ``` @tag :capture_stdio @tag :capture_stderr @tag :capture_log ``` They may receve options: ``` @tag capture_stdio: "input to be given, no need for buffer" @tag :capture_stderr...
Yes, I understand that. My comment was not about the get_key/spec part, but about ensure_loaded. This is a very expensive operation and, if it is only needed for plug-ins, then...
I have updated it to use Keyword.take. It should also fix #20.
Ideally this would be merged on `maint` because it fixes a regression on OTP 27 but it is a conceptually large change. My suggestion is to merge it to master...
Please don't merge this yet. I have tried this branch in a project and, while I didn't notice any bugs, compilation times for Elixir (which loads several modules) was affected...
False alarm, I had mixed my Erlang versions. Overall, I didn't measure any performance degradation in my usual code loading benchmarks. :)
Glad to hear so! 🎉 Code loading is a state machine and the previous version was encoding the states via anonymous functions and in two separate queues, which made it...
As long as we are comfortable with potentially doing a 27.2.1 with this commit reverted, it sounds good to me. :D
@kikofernandez let me know if you want me to do the squashing. :)