José Valim

Results 805 comments of José Valim

For completeness, the operations that will be affected by this are: mutate, summarize, filter, arrange, distinct.

To me, a dataframe is a map of 1-dimensional tensors with the column names as keys. In fact, `Nx` defines a `Nx.Container` protocol. My hope is that you can fully...

I am not sure if we should do the `to_tensors_map` version. Today you can easily get a column as a series right? This means you can get a tensor for...

So what do you think about `DF.to_tensor(df, ["height", "width"])`? This ends up a 2d tensor.

I was asking both/everyone. :) > Would this allow column names to be shared or is it a normal tensor? What do you mean?

One thing is that tensor names are atoms and columns are strings. But perhaps we could introduce a convention: if the column name is a string, then it is not...

> Whoops, just reread the docs. Turns out tensor names actually identify axes not columns, DataFrame column names do not map onto names on Nx.Tensor. If we were to do...

I think there are no blockers, it is just that nobody implemented the solution so far. I think the implementation is similar to maps, yeah. I would even make it...

Congratulations on shipping this upstream!

@joshuataylor can you please rebase? I think you can pretty much discard your changes to `expressions.rs` and we should be good to go!