José Simões

Results 285 comments of José Simões
trafficstars

@AdrianSoundy I've submitted a PR against your fork with those improvements on replacing the template with a CMake macro. Please review.

@AdrianSoundy FYI: I've just rebased this AdrianSoundy/nf-interpreter#71. Please review when you have the opportunity so we can get this one merged.

@jooos5 can you please address the build failure? (also make sure to pull the latest changes from upstream)

@jooos5 any progress on this please? Just that more UI code is changing and it can have impact here. The longer this remains stalled harder to keep up. 😉

@jooos5 any chance you can sign the CLA? The team will take over and fix the remaining issues.

@jooos5 just scrool up and you'll see the following. You have to click there to sign. ![image](https://user-images.githubusercontent.com/1881520/179210393-15994fde-ea1d-44e1-a06e-b0f56e0344ec.png)

> what should I choose to allow the team to fix problems? You just have to sign the CLA. Only after that your code can be merged and after that...

@jooos5 @networkfusion I've fixed the build error. Please confirm if this is working as it is now so it can be merged.

@jooos5 can you please merge this PR with the code style fixes? https://github.com/jooos5/nf-interpreter/pull/7

@jooos5 can you please address the review comments so this can move forward?