easy-reddit-downloader icon indicating copy to clipboard operation
easy-reddit-downloader copied to clipboard

Download stops after first subreddit/user when providing a list

Open knoxitus opened this issue 1 year ago • 1 comments

The scripts exits after completing the first subreddit or user when providing a list of subreddits/users.

The only special settings I used ist to set the number of posts to max (0 at the propmt). At least it should be higher than the available posts of the subreddit.

I identified the issue is on this condition: https://github.com/josephrcox/easy-reddit-downloader/blob/9c92f76e906c1f19ee7e8643233571fdc92beb25/index.js#L1080

With those changes it worked for me, but not sure if it's fixed correctly at all:

		if (numberOfPostsRemaining()[0] === 0 ||
			(lastAPICallForSubreddit && lastPostId === currentAPICall.data.children[responseSize - 1].data.name) ||
			(numberOfPostsRemaining()[1] === responseSize && responseSize < 100)) {

Also the amount of posts of a subreddit or user has affects to the condition, if it has more than 100 or not.

Once workarounded this condition, I also got stuck here in the console, which actually makes no sense when running with testing mode params: https://github.com/josephrcox/easy-reddit-downloader/blob/9c92f76e906c1f19ee7e8643233571fdc92beb25/index.js#L1121

				} else if (!testingMode && !config.download_post_list_options.enabled) {

knoxitus avatar Apr 23 '24 17:04 knoxitus

@knoxitus Do you mind submitting a PR? The lines got switched up with the latest PRs merged in, but if you can get that – I can test and review!

josephrcox avatar Jun 01 '24 03:06 josephrcox