Joseph Guillaume

Should commented code be included in the built package?

2

lintr warning: > ##[warning]Commented code should be removed. Or is it already, and this warning an artifact of how the CI is run?

Formalise naming conventions

1

tidyverse recommends snake_case for naming functions and objects. Names in hydromad are currently a mix of camelCase and base R (i.e. where the words that make up a function name...

> ##[warning]local variable assigned but may not be used Identifying the location of these will either require running lintr locally or waiting until the number of annotations is reduced.

Provide a style file https://github.com/DoozyX/clang-format-lint-action using options in https://clang.llvm.org/docs/ClangFormatStyleOptions.html 1. ```C Rprintf("U optim loop: Ut = %.3f, ct = %.3f, c = %.3f\n", Utest, ctest, c); ``` Leaving one variable...

Improve standard_ci annotations

2

It seems all of the standard_ci annotations are listed as line 1 in .github, which limits their usefulness.

Provide mechanism for hydromad.stats to use external packages (with appropriate conversions): * hydroGOF package (Mauricio Zambrano-Bigiarini, 2017) * https://cran.r-project.org/web/packages/hydrostats/

Provide clean patches from clinter

1

At the moment the log needs to be used and the timestamps removed. Copying directly from github seems to only select small sections of text at once. Initial efforts at...

Separate PET calculation from individual models

1

Add to hydromad as an optional separate component, but still allow it to be specified as data

Hydrodesktop facilitates obtaining data

Allow hydromad model to be run from PEST by auto-creating appropriate template files