Joseph Guillaume

return Psnow and Prain?

https://github.com/josephguillaume/hydromad/blob/master/R/prefilters.R#L20

PR checklist shouldn't imply all boxes need to be checked?

5

# Issue: PR checklist shouldn't imply all boxes need to be checked? ## Issue summary: PR checklist is used to show a progress bar, but actually not all checkboxes need...

- absorbScale.hydromad.cwi - absorbScale.hydromad.scalar is also used by absorbScale.hydromad.dbm, absorbScale.hydromad.intensity, absorbScale.hydromad.runoffratio Tests should create hydromad object with these models and check that bias is zero (and no errors occur)

Avoid 1:ncol(...) expressions, use seq_len

3

Lintr warning: > ##[warning]Avoid 1:ncol(...) expressions, use seq_len.

See https://lorenzwalthert.github.io/precommit/ for example https://github.com/josephguillaume/hydromad/issues/95

Either suppress or fix, depending on whether they are relevant to the test. A consistent approach across all tests is probably a good idea. > test-calibration-results.R:34: warning: cwi+armax optim/SRIV gives...

Test using dream from BayesianTools

1

There is another implementation of dream already on CRAN. https://cran.r-project.org/web/packages/BayesianTools/index.html Let's test whether it can be used as a replacement for ours.

gr4j.ranges is exported and awbm.ranges is not Model test suites should check that all are exported.