Simhyd documentation

[WillemVervoort]

All Submissions:

• [x] Have you followed the guidelines in our CONTRIBUTING document?
• [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Closes #37

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue. List the bug ID if applicable)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing core functionality to change)

This completes the documentation for simhyd. However, I have split the simhyd.R code to have a separate simhydrouting.R as this was cleaner and follows the "sma" and "routing" convention better. I hope this does not break any other features. The documentation for the routing and simhyd is similar except for the parameters.

It is still giving me the testthat error, even though I am even with the master from Joseph == testthat results ======================================== [ OK: 256 | SKIPPED: 3 | WARNINGS: 22 | FAILED: 1 ]

1. Failure: formula works within functions (@test-statistics.R#82)

[codecov-io]

Codecov Report

Merging #182 (a289bff) into master (33bb1ec) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #182   +/-   ##
=======================================
  Coverage   66.64%   66.64%           
=======================================
  Files         109      110    +1     
  Lines        6736     6736           
=======================================
  Hits         4489     4489           
  Misses       2247     2247           

Impacted Files	Coverage Δ
R/simhyd.R	98.46% <ø> (+28.13%)	:arrow_up:
R/simhydrouting.R	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 33bb1ec...a289bff. Read the comment docs.

[josephguillaume]

As discussed, Willem, could you see if you want to change the example for simhyd? Maybe using Murrindindi?

[josephguillaume]

@WillemVervoort - sorry it's taken me so long to get back to this. Are you happy to see if simhyd performs better on the built-in Murrindindi dataset rather than the Cotter?