Joseph Guillaume

'paretoTimeAnalysis.crossvalidation' and 'paretoTimeAnalysis.data.frame' are addressed by https://github.com/josephguillaume/hydromad/commit/781f9aa84d0e0d7f30f2a76f6634771865d2e1f0

Simhyd will be addressed by https://github.com/josephguillaume/hydromad/issues/37

Shouldn't be user facing? > 'absorbScale' 'buildCachedObjectiveFun' 'ccfForLags' 'filter_loss' Needs documentation? > 'eigen.plot.single' 'fdc.allpoints' 'fdc.sample' 'tfParsConvert' 'buildTsLikelihood' 'findThresh' 'fitDbmToPeaks' 'lambda.inverse.fit' 'lambda.inverse.sim' 'numericSummary' `makePrefilter` needs to be discussed: https://github.com/josephguillaume/hydromad/issues/76

In principle, `absorbScale` does need to be exported because it is called by `update.hydromad` and therefore user models or external packages might want to use it. Default is a no-op,...

Tests for absorbScale to be provided by https://github.com/josephguillaume/hydromad/issues/94

Thanks! We probably need to add tests for these functions

> ##[warning]Avoid 1:NCOL(...) expressions, use seq_len. > ##[warning]Avoid 1:NROW(...) expressions, use seq_len. > ##[warning]Avoid 1:length(...) expressions, use seq_len. > ##[warning]Avoid 1:nrow(...) expressions, use seq_len.

There's `seq_along(along.with)` and `seq_len(length.out)`. The first just uses the length of the object. The behaviour is unclear for matrices, so it's better to do `seq_len(NROW(object))` for instance. These shouldn't be...

cl is a global variable. Ideally other fixes will eventually be found for all the others

Also utils::globalVariables(c("swimp_core"))