Joseph Guillaume

Results 141 comments of Joseph Guillaume

Basic tutorial should include common gotchas, e.g. from https://groups.google.com/g/hydromad-users/c/sGdxOnlS5AU/m/716wTAxaBgAJ - Shortening warmup with short data - Not using monthly NSE for less than monthly data

Used by https://github.com/josephguillaume/hydromad/blob/master/demo/ACTCatchments.R

Cotter and Corin are now partial duplicates. We probably want a new authoritative dataset that includes PET and T for the purposes of HBV. We'll need to make sure no...

Honestly, I'm not entirely sure. The intended behaviour is that the `%dopar%` block is executed in remote sessions and it seems that without `for (e in export) assign(e, get(e), envir...

Or maybe `export` should just be converted into an environment, but then it may need to inherit from .globalEnv It's rather annoying that this has to happen at every iteration,...

That's hilarious - maintains the exact same functionality but because of the obfuscation R CMD check doesn't complain. A simple addition in light of Joel's comment would be to name...

I wouldn't have thought just using `new.env()` would work - the contents of `global_env` would not be available to the lines below. I meant ``` %dopar% { with(export,{ hydromad.options(opts) thisMod

@buzacott - your help in testing would be great! My memory is pretty vague, but according to the relevant commit, the issue is that "predict looks for functions in .GlobalEnv,...

Here's a test case, though I haven't checked that it is actually running parallel. ``` library(hydromad) library(doParallel) library(foreach) library(iterators) #iter registerDoParallel() data(Cotter) obs

And this is an example of something that would fail because the objective used calls variables in the global environment. ``` myObjective