node-browserchannel icon indicating copy to clipboard operation
node-browserchannel copied to clipboard
verified publisher icon josephg

Fix dynamic cors setting

Open reem opened this issue 8 years ago • 3 comments

Unfortunately I missed some cases in my last PR! I added new tests to ensure that cors headers are correctly sent in all cases and refactored the internal options interface to ensure this sort of error is now impossible.

Also included is a change to npm test to ensure that it always runs against the latest coffeescript code.

reem avatar May 04 '17 02:05 reem

I'm not using this library for anything (I moved my projects to websockets a few years ago and haven't looked back). Do you want commit & npm publish access so you can fix this stuff yourself?

josephg avatar May 04 '17 03:05 josephg

Yeah that would be great, we are still using this project.

EDIT: my npm username is also reem

reem avatar May 04 '17 23:05 reem

Great. invite sent, and npm owner added. Merge at your leasure.

node-browserchannel josephg$ npm owner add reem
+ reem (browserchannel)

josephg avatar May 05 '17 03:05 josephg