midi-relay icon indicating copy to clipboard operation
midi-relay copied to clipboard

Program crashes when refreshing the page on Brave

Open datadata95 opened this issue 1 year ago • 4 comments

Describe the bug Crashes when refreshing the page. Running the latest version of Midi-Relay. It also makes duplicates of the configuration when importing an exported one, which could make sense since the original config is there but won't display.

To Reproduce Steps to reproduce the behavior:

  1. Start Midi Relay and open it's web config.
  2. Web config turns out blank.
  3. Refresh it and the triggers list comes up.
  4. Refresh it again and the software crashes.

Expected behavior The list of triggers would open immediately as web page is displayed.

Screenshots If applicable, add screenshots to help explain your problem.

Skärmavbild 2024-02-06 kl  14 37 51 Skärmavbild 2024-02-06 kl  14 42 00

Desktop (please complete the following information):

  • OS: Mac OS Monterey
  • Version 12.7.2

Additional context Error log:

Unhandled Error TypeError: Cannot read properties of undefined (reading 'id') at /Applications/midi-relay.app/Contents/Resources/app.asar/midi.js:965:9 at Array.find () at deleteTrigger (/Applications/midi-relay.app/Contents/Resources/app.asar/midi.js:964:11) at Object.deleteTrigger (/Applications/midi-relay.app/Contents/Resources/app.asar/midi.js:997:3) at Object.deleteTrigger (/Applications/midi-relay.app/Contents/Resources/app.asar/util.js:90:8) at Socket. (/Applications/midi-relay.app/Contents/Resources/app.asar/api.js:130:11) at Socket.emit (node:events:390:28) at Socket.emitUntyped (/Applications/midi-relay.app/Contents/Resources/app.asar/node_modules/socket.io/dist/typed-events.js:69:22) at /Applications/midi-relay.app/Contents/Resources/app.asar/node_modules/socket.io/dist/socket.js:704:39 at processTicksAndRejections (node:internal/process/task_queues:78:11)

datadata95 avatar Feb 06 '24 13:02 datadata95

Fix: don’t refresh the page.

Jk.

I will see if I can fix that.

josephdadams avatar Feb 08 '24 01:02 josephdadams

Fix: don’t refresh the page.

Jk.

I will see if I can fix that.

Thanks!

The problem is though, that it seems the application wont remember the configuration when started and displays the page empty, or the things are there but not seen. If I import the config it generates duplicates, which seem to be the way it should work.

Tried in Safari as well with the same result.

datadata95 avatar Feb 12 '24 11:02 datadata95

Can you send me your exported triggers? I am trying to recreate this issue and cannot.

josephdadams avatar Feb 15 '24 12:02 josephdadams

midi-relay-triggers_2024_2_6.txt

midi-relay-triggers_2024_2_15.txt

I'm currently on Companion 3.2.1

datadata95 avatar Feb 15 '24 14:02 datadata95