TallyArbiter icon indicating copy to clipboard operation
TallyArbiter copied to clipboard

Setup CI for nightly CLI releases after every commit to the `master` branch

Open hrueger opened this issue 3 years ago • 8 comments

I suggest the following:

  • Github Action workflow which runs on pushes to the master branch (or better add the following steps to the already exisiting build workflow)
  • Append -nightly-[time] to the package.json's version field. [time] is the current timestamp.
  • build and push the version to npm with the --tag nightly

You can then get the latest version with npm I tallyarbiter@nightly.

This makes sense for the CLI and the Docker Image but what about the Desktop Versions? If we want to have nightly versions for those, too, we'd need to create a GH pre-release every time in order to host the assets. I don't know if that makes sense or not.

Originally posted by @hrueger in https://github.com/josephdadams/TallyArbiter/issues/125#issuecomment-888610616

hrueger avatar Jul 30 '21 18:07 hrueger

I'm working on an e2e testing system running in Github Actions with Cypress. ASAP I'll open a draft PR.

MatteoGheza avatar Jul 30 '21 18:07 MatteoGheza

I could see end users on electron wanting “the latest”. I’m also ok with just releasing new public releases more often since it is so simple to do.

josephdadams avatar Aug 01 '21 20:08 josephdadams

What would it take to have 2 streams for people? People who are ok running the nightly builds and updating as soon as possible, and people who want more stability so they keep to the major updates.

JTF4 avatar Aug 02 '21 02:08 JTF4

What we are doing now + the nightlies. We just limit our release tags to what we consider stable.

josephdadams avatar Aug 02 '21 03:08 josephdadams

Yea. But what I'm wondering is if we can offer a automatic upgrade path for people who are ok with nightly builds and just clicking upgrade when they want rather than wait for a major release.

Or, are we planning on doing major releases often enough that it really shouldn't matter?

OR, am I completely miss understanding this whole thing (as you know, I have never used GitHub actions) 😊

JTF4 avatar Aug 02 '21 03:08 JTF4

I’m saying we can do non beta releases as often as we want. So it should keep everyone happy.

josephdadams avatar Aug 02 '21 11:08 josephdadams

Ahhhhhh

JTF4 avatar Aug 03 '21 04:08 JTF4

I'd prefer @josephdadams way to just do "normal" releases more often. As far as I know, it is quite a lot of work to setup a beta release channel and I don't know if that is possible with the GitHub Releases provider for electron-builder.

hrueger avatar Aug 04 '21 12:08 hrueger