Joseph Crowell

Results 29 comments of Joseph Crowell

The first thing I notice is that the whitespace is different.

Yeah those files can't be merged as is but could have some custom build settings that he used.

In regards to the code formatting, neo, do you guys usually follow any rules on whitespace?

I'm talking about things like do you use 4 or 8 spaces for tab. It looks like Ehamloptiran used a code beautifier and corrected the tabs to 8 spaces while...

> You can ignore whitespace during DIFFs so that it makes it easier for you to review. Good to know. :) So it can be done in the gitlab diff...

Oh, oops I meant github. ;)

This hides the mute button/icon, hides the muted label, keeps the site favicon, and puts a green border across the bottom to indicate a tab is unmuted. ```css .tab-icon-overlay:not([soundplaying])[muted], .tab-secondary-label:not([soundplaying])[muted]...

This hides the mute button/icon and puts a green border across the bottom to indicate a tab is unmuted. ```css .tab-icon-overlay:not([soundplaying])[muted], .tab-secondary-label:not([soundplaying])[muted] { display: none !important; } .tab-icon-stack[muted] > .tab-icon-image,...

Renaming the classes folder to Classes does work, but I'm going to stick to the Winter way moving forward. Martin had a habit of breaking this plugin with incorrect case...