Joseph Birkner

Results 24 comments of Joseph Birkner

Since the last commits are about three years old (including a stalled PR for v2?), it seems like this repo might have been abandoned.

Note that pybind11 is already extensively used in zswag ;)

Wasn't this solved for the JSON conversion in 2.6? πŸ€”

Thanks a lot for taking the time to write this detailed explanation @mikir ! I didn't know that zserio allows such declarations. The best fix that I can think of...

One of the problems in this case is `import outer.inner as inner` in outer's `__init__.py`. It's redundant. Python automatically detects submodules. Edit: Please see next comment. ~~Edit: And yes, the...

An easy solution might be to hide the original import structure completely behind an *_impl* (or similar) package: ``` outer/ β”œβ”€β”€ _impl/ β”‚ β”œβ”€β”€ __init__.py β”‚ β”œβ”€β”€ bar.py β”‚ └──...

Sounds very good. Sorry for my trail of edits, I had to go through quite a thought process myselfπŸ˜… The `api`-way works nicely for now. And it looks like we...

That makes sense. I am very ok with the current solution, so you may close this issue at your convenience πŸ˜ƒ

I think that [`zserio_add_library`](https://github.com/ndsev/zserio/blob/4d9a3ede086e7aeeb1b481b3f15a72be92713342/cmake/zserio_utils.cmake#L51) will actually work fine! We will investigate and report back.

After looking into it a bit more the existing function did not work out for us because it does not support globbing. We added the functionality we need in this...