Joey Arhar

Results 314 comments of Joey Arhar

> Ha. Yeah that’s a very good point. Ok, that serves, at least for me, as a good enough reason to move this to HTMLElement. If we want to expand...

As per the resolution in https://github.com/openui/open-ui/issues/617#issuecomment-1278147334 I have removed popup=hint from this PR. Hopefully the algorithms still make sense, particularly hide-all-pop-ups-until

> The "pop-up visibility state" needs to have an initial state, probably hidden? This could optionally be folded into the list of element state including "pop-up previously focused element", or...

> A big part of the proposal was writing up https://github.com/whatwg/html/wiki/dialog--initial-focus,-a-proposal#improving-conformance-requirements-and-examples as spec text, to replace the current single sentence "The [dialog](https://whatpr.org/html/8199/interactive-elements.html#the-dialog-element) element represents a part of an application that...

> This does not implement the change where calling showModal() on `` will cause the dialog itself to get focus. Probably the best way to spec that is to change...

Thanks for the review @domenic! I believe I've addressed all your comments

I finally got a draft of the implementation in chromium done, and here is a new test and many other test changes to account for the focus ring being rendered...

> This does not implement the change where calling showModal() on `` will cause the dialog itself to get focus. Does this mean that non-modal dialogs should not be focusable?...

> Maybe if you add pointer-events: none !important like you did for popover=""?? That did the trick! I've added it to this PR > I don't think we've given a...

I [implemented `color-contrast()` in chromium](https://chromium-review.googlesource.com/c/chromium/src/+/3232100) a little while ago, but I've been holding off on shipping it because I got feedback that I was doing the whole calculation at parse...