ember-focus-trap icon indicating copy to clipboard operation
ember-focus-trap copied to clipboard
verified publisher icon josemarluedke

Peerdep on ember-source too strict?

Open abeforgit opened this issue 2 years ago • 1 comments

PR #80 adds ember 4 as a minimum peerdep version, but according to the README, ember 3.16 and up is still supported?

Ran into this cause our 3.28 ember-try CI tests failed all of a sudden, with npm (node 18, also supported as per the readme) not able to resolve the peerdep.

If support was dropped, I'd also expect 1.1.0 to be a breaking release instead of a minor one.

abeforgit avatar Aug 24 '23 20:08 abeforgit

Tests are run against Ember 3.16 and 3.20: https://github.com/josemarluedke/ember-focus-trap/blob/760b3bc8ec1da4c8a12dab780223788b6b158324/.github/workflows/ci.yml#L39-L42

The peer dependency was added in #80. The PR does not mention any reason for only allowing Ember >= 4.0 in peer dependency. So likely just a bug introduced by mistake.

jelhan avatar Feb 05 '24 22:02 jelhan