docfy Remark / Rehype are moving entirely to ESM

Remark / Rehype are moving entirely to ESM

Open NullVoxPopuli opened this issue 3 years ago • 9 comments

what does this mean for docfy and docfy config files?

May 04 '21 21:05 NullVoxPopuli

Do you have any resources about this change? We will need to investigate. Probably will restrict what node versions are compatible at least.

May 07 '21 18:05 josemarluedke

Just this thread: https://github.com/wooorm/lowlight/issues/37#issuecomment-832342443

May 07 '21 19:05 NullVoxPopuli

https://github.com/unifiedjs/unified/issues/121

May 08 '21 13:05 wooorm

I had forgotten about this, but was reminded during this discussion when I tried to upgrade to hljs@11

https://github.com/remarkjs/remark-highlight.js/issues/38#issuecomment-865356421

Jun 21 '21 22:06 NullVoxPopuli

it's currently not possible to use hljs@11 with remark-highlight.js atm :(

Jun 21 '21 22:06 NullVoxPopuli

@NullVoxPopuli have you seen how the move to ESM affects Docfy?

Regarding highlight, it seems we should be using rehype-highlight moving forward. Have you had success using it?

Jun 23 '21 18:06 josemarluedke

ESM affects Docfy?

once all the dependencies are updated, things should "just work"? (though, seems like there must be a switch to rehype)

Have you had success using it?

haven't tried yet, because I've been waiting for all the dependencies to switch to hljs@11 support

Jun 23 '21 18:06 NullVoxPopuli

Is it time for upgrades? looks like rehype-highlight and all sub-deps are using hljs v11 which means we can have hifi glimmer highlighting!!! :D

Sep 14 '21 13:09 NullVoxPopuli

@NullVoxPopuli I think we should try to upgrade yes. It would be awesome to get the new features. Any change you have cycles to get that going?

Sep 16 '21 00:09 josemarluedke