docfy icon indicating copy to clipboard operation
docfy copied to clipboard

Site: Add Embroider

Open josemarluedke opened this issue 4 years ago • 2 comments

TODO:

  • [ ] Fastboot content is not cleared/replaced/hydraded (https://github.com/ember-fastboot/ember-cli-fastboot/issues/785)
  • [ ] Prember didn't seem to work with Embroider. (https://github.com/ef4/prember/issues/59)
  • [ ] Rebuilds don't pick up markdown changes, probably due to the static nature of Embroider.

    Setting up a env var with the following EMBROIDER_REBUILD_ADDONS=@docfy/ember makes embroider rebuild the markdown on file changes..

josemarluedke avatar Sep 06 '20 23:09 josemarluedke

@josemarluedke Wanted to look at this issue but can get the app to build. I'm running into issues like this.

2 import { Context } from '@docfy/core/lib/types';
                          ~~~~~~~~~~~~~~~~~~~~~~~

src/plugins/replace-internal-links-with-docfy-link.ts:2:38 - error TS2307: Cannot find module '@docfy/core/lib/types' or its corresponding type declarations.

2 import { Context, PageContent } from '@docfy/core/lib/types';
                                       ~~~~~~~~~~~~~~~~~~~~~~~

kiwiupover avatar Sep 18 '20 16:09 kiwiupover

@kiwiupover thanks for your interest in looking at this. For development, you do need to build the core first for the types to be generated.

  1. cd packages/@docfy/core
  2. yarn compile

I hope this helps.

josemarluedke avatar Sep 18 '20 16:09 josemarluedke