python-github-backup icon indicating copy to clipboard operation
python-github-backup copied to clipboard

Published 20 hours ago • verified publisher icon josegonzalez

Does Not Include Reviews

Open timm3 opened this issue 6 years ago • 3 comments

Review details are not backed up.

Some of the review comments might be, but the actual reviews are not.

timm3 avatar Jul 30 '19 21:07 timm3

We are also seeing this behavior. Summary of observations with the CLI arguments --pull-comments --pulls --pull-commits,

  • We DO backup the commits SHAs in a PR.
  • We DO backup PR Review comments attached to code fragments.
  • We DO backup the comment associated with the PR description.
  • We DO NOT backup loose PR comments not associated with a review.
  • We DO NOT backup PR comments associated with a review but not associated with code (typically the last comment in the review).

hanryhu avatar Jan 14 '20 16:01 hanryhu

Probably related, I just noticed that a code comment on a merge commit (i.e. not directly associated with the PR) also does not seem to be backed up.

floe avatar Mar 31 '20 11:03 floe

Pull requests welcome.

josegonzalez avatar Apr 04 '20 21:04 josegonzalez