josefsabl

Results 28 comments of josefsabl

> I am not quite sure what you're talking about to be honest (phpstan wasn't a thing when I was writing PHP..) but I'd be happy to see these issues...

Yes, this works. But if there is disabled textarea with text selected somewhere in the page, the selected text gets copied instead of the text that is sent to copy-to-clipboard....

I had to install FF to work on this as well :-) In Chrome it works as expected. Didn't test other browsers.

- I don't think `selection.rangeCount` has anything to do in case of textarea. I was debugging (console logging) your script and I believe the rangeCount was 0. - No, `active.blur`...

Wow, you are fast 😅❤️. I will check on monday.

Unfortunately it is still not working. The problem is that `$this->validNamespace('')` here `\Kcs\ClassFinder\Iterator\FilteredComposerIterator::146` is evaluated as false and the fallback code never gets executed. My `namespaces` property contains exactly one...

I am now looking into your tests in the fixing commit. Indeed it is a misunderstanding of the problem or maybe even the fallback directory feature (?). The fallback doesn't...

I understand and also understand fixing it would introduce a BC break. Please note I spent good amount of time trying to figure out what is going on (Double, triple,...