Jose Celano

Besides, when you try to ban an admin it says "user not found" instead of "admins cannot be deleted"

> @josecelano Three of your tests now fail, since they use different remote_addresses for the connection cookie. > > ``` > test > udp::handlers::tests::announce_request::using_ipv4::an_announced_peer_should_be_added_to_the_tracker ... > remote_address: 127.0.0.1:8080, time_extent: TimeExtent...

ACK 2911f3d05587bc0501979e76347c73279456b0fe

hi @da2ce7 @WarmBeer I have added three tests: - [should_return_a_bad_request_response_when_the_client_sends_an_empty_request](https://github.com/torrust/torrust-tracker/pull/96/files#diff-4b41e272c2b5b49b68ebf4dff4c646aabc672609db1ef4248db9145960ac53d8R210-R223) - [should_return_a_connect_response_when_the_client_sends_a_connection_request](https://github.com/torrust/torrust-tracker/pull/96/files#diff-4b41e272c2b5b49b68ebf4dff4c646aabc672609db1ef4248db9145960ac53d8R225-R240) - [should_return_an_announce_response_when_the_client_sends_an_announce_request](https://github.com/torrust/torrust-tracker/pull/96/files#diff-4b41e272c2b5b49b68ebf4dff4c646aabc672609db1ef4248db9145960ac53d8R242-R293) After adding the third one, I started having random failures for the third one. First, I...

Sometimes I get this message: ``` 2022-10-06T19:36:29.518810036+01:00 [torrust_tracker::logging][INFO] logging initialized. 2022-10-06T19:36:29.518884993+01:00 [torrust_tracker::jobs::udp_tracker][INFO] Starting UDP server on: 127.0.0.1:6969 test udp_tracker_server::should_return_a_bad_request_response_when_the_client_sends_an_empty_request ... ok thread 'udp_tracker_server::should_return_an_announce_response_when_the_client_sends_an_announce_request' panicked at 'called `Result::unwrap()` on an `Err`...

hi @WarmBeer @da2ce7, I've also added the test for the scrape request. I think it's ready for review. I only check basic behaviour. Only the happy path, and I only...

hi @da2ce7 @WarmBeer, In this [PR](https://github.com/torrust/torrust-tracker/pull/91) I've added some tests for the current behavior. I think the peer IP is replaced only if it's a loopback IP (both IPv4 to...

@da2ce7 @WarmBeer I'm working on another [PR](https://github.com/torrust/torrust-tracker/pull/94) to add tests to the TorrentPeer constructor from the requests. This is where all this logic is implemented right now.

Cool @da2ce7! I like having real speed metrics. Do you want to include all the options in the final version or just record why we choose one of them?

> Yes I removed almost all the abstractions that you provided, as I'm still learning rust, I wish to use the standard library as much as possible. I do not...