react-image-picker-editor icon indicating copy to clipboard operation
react-image-picker-editor copied to clipboard

Version 1.3.4 has dependency on react 17

Open ericwhitlock opened this issue 1 year ago • 1 comments

Hi Jose. Great library. Thanks for your efforts on it.

I am running react 18.2.0 and saw that version 1.3.4 of your library shows "Ready to React 18" at https://www.npmjs.com/package/react-image-picker-editor but after running npm i I ran into the following error:

Could not resolve dependency:
npm ERR! peer react@"^17.0.2" from [email protected]
npm ERR! node_modules/react-image-picker-editor
npm ERR!   react-image-picker-editor@"^1.3.4" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/react
npm ERR!   peer react@"^17.0.2" from [email protected]
npm ERR!   node_modules/react-image-picker-editor
npm ERR!     react-image-picker-editor@"^1.3.4" from the root project

Is this due to your package.json below or am I doing something wrong? https://github.com/josealejandro2928/react-image-picker-editor/blob/6a9f18ca950b7d908c7667d7aa8fc762a8fb21ab/package.json#L30-L32

ericwhitlock avatar Jun 01 '24 14:06 ericwhitlock

Yep, maybe is an issue the declarative way of the package Json. Try npm i --force

On Sat, Jun 1, 2024, 4:59 PM Eric Whitlock @.***> wrote:

Hi Jose. Great library. Thanks for your efforts on it.

I am running react 18.2.0 and saw that version 1.3.4 of your library shows "Ready to React 18" at https://www.npmjs.com/package/react-image-picker-editor but after running npm i I ran into the following error:

Could not resolve dependency: npm ERR! peer react@"^17.0.2" from @.*** npm ERR! node_modules/react-image-picker-editor npm ERR! react-image-picker-editor@"^1.3.4" from the root project npm ERR! npm ERR! Conflicting peer dependency: @.*** npm ERR! node_modules/react npm ERR! peer react@"^17.0.2" from @.*** npm ERR! node_modules/react-image-picker-editor npm ERR! react-image-picker-editor@"^1.3.4" from the root project

Is this due to your package.json below or am I doing something wrong? https://github.com/josealejandro2928/react-image-picker-editor/blob/6a9f18ca950b7d908c7667d7aa8fc762a8fb21ab/package.json#L30-L32

— Reply to this email directly, view it on GitHub https://github.com/josealejandro2928/react-image-picker-editor/issues/15, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI2QHWJR6B4ERLZE3NHWR4LZFHOUJAVCNFSM6AAAAABIUG7QHWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMZDSMJYGY4TCMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

josealejandro2928 avatar Jun 01 '24 15:06 josealejandro2928

Closing

josealejandro2928 avatar Sep 16 '24 17:09 josealejandro2928

close

josealejandro2928 avatar Sep 16 '24 17:09 josealejandro2928

Can you please reopen this issue and update your package.json to support React 18. There are multiple possibilities:

 "peerDependencies": { 
   "react": ">=17.0.2" 
 },

or if you need at least a certain React 18 version

 "peerDependencies": { 
   "react": "^17.0.2 || >=18.1.0" 
 },

UncleSamSwiss avatar Feb 19 '25 10:02 UncleSamSwiss

Sorry, didn't even remember I had already created #19 some time ago :-). Thanks for merging it!

Of course this can now remain closed.

Do you have an ETA on the npm release?

UncleSamSwiss avatar Feb 24 '25 14:02 UncleSamSwiss