null-ls.nvim icon indicating copy to clipboard operation
null-ls.nvim copied to clipboard

ts-standard support

Open Suyashtnt opened this issue 2 years ago • 6 comments

Issues

  • [X] I have checked existing issues and there are no existing ones with the same request.

Feature description

Add support for the typescript version of standardjs, ts-standard

Help

Yes, but I don't know how to start. I would need guidance

Implementation help

~~Could I just copy paste code from the normal standard one? They both share the same API Also, how can I write tests?~~ ~~done both. PR soon:tm:~~ ~~How can I get the file name when declaring the args?~~ Since the formatted version goes to stdout, how can I put that into the file its formatting?

Suyashtnt avatar Apr 30 '22 07:04 Suyashtnt

I suspect the standardjs formatter can be adapted to work in this case (by default, most of our formatters will read from stdout and apply changes to the buffer, so that shouldn't be an issue).

jose-elias-alvarez avatar Apr 30 '22 18:04 jose-elias-alvarez

I suspect the standardjs formatter can be adapted to work in this case (by default, most of our formatters will read from stdout and apply changes to the buffer, so that shouldn't be an issue).

for me it did not for some reason. How can i tell it to do so? Its the only thing holding me back from PRing

Suyashtnt avatar Apr 30 '22 18:04 Suyashtnt

You can try enabling debug mode and see what the output looks like.

jose-elias-alvarez avatar Apr 30 '22 18:04 jose-elias-alvarez

image what

Suyashtnt avatar Apr 30 '22 19:04 Suyashtnt

No idea. If you open up a draft PR with what you have so far, I can take a closer look and see if anything jumps out at me.

jose-elias-alvarez avatar Apr 30 '22 19:04 jose-elias-alvarez

For reference: #1033 will close this issue and should provide a good base if anybody wants to pick this up.

jose-elias-alvarez avatar Oct 11 '22 20:10 jose-elias-alvarez