null-ls.nvim icon indicating copy to clipboard operation
null-ls.nvim copied to clipboard

Published 20 hours ago • verified publisher icon jose-elias-alvarez

Support for PMD 7.x

Open IlyasYOY opened this issue 1 year ago • 2 comments

Issues

  • [X] I have checked existing issues and there are no existing ones with the same request.

Feature description

I guess it'd be useful to add built in support for PMD 7.x: https://github.com/pmd/pmd/issues/3898

The new version breaks compatibility.

Help

Yes

Implementation help

I have an example of PMD 7 usage. Null-ls may provide one additional PMD 7 source or put an advice/notice in documentation of the old one.

https://github.com/IlyasYOY/dotfiles/blob/master/config/nvim/lua/plugins/lsp.lua#L188

There are no new wrappers around run.sh required now.

PS. I also use FILENAME there to run scanning. It simply speeds things up a bit.

IlyasYOY avatar Jun 05 '23 19:06 IlyasYOY

Since the new version breaks compatibility, do you think it's likely that users / projects will continue using the old version? If so, it might make sense to have a new source for the new version once it's released.

jose-elias-alvarez avatar Jun 06 '23 12:06 jose-elias-alvarez

I personally think that users won't even notice changes in CLI API. Almost all project use Maven or Gradle plugins to handle PMD interactions. Users don't even download the CLI themselves.

So, I think null-ls may break compatibility, devs actively using null-ls will be able to update PMD binary easily. The changes are almost neglectable. Users will be able to go back to 6.x compatible option with a few lines of code (as I did 6.x -> 7.x).

But I'd wait for some more PMD to show up here with their feedback.

IlyasYOY avatar Jun 06 '23 18:06 IlyasYOY