workerpool icon indicating copy to clipboard operation
workerpool copied to clipboard
verified publisher icon josdejong

fix: :bug: process.exitCode instead of calling process.exit to allow cleanup

Open pcace opened this issue 1 year ago • 3 comments

closes https://github.com/josdejong/workerpool/issues/429

see https://github.com/josdejong/workerpool/issues/429

The test sometimes failed, i guess because it now takes a bit longer to finish code and exit. after using 2000 it never failed on my machine. Hope thats ok.

pcace avatar Dec 18 '24 12:12 pcace

Thanks for your PR @pcace, and sorry for the late reply.

Two remarks:

  • Can you have a look at the inline comment of Bean?
  • How can we reproduce your issue, so we can test whether this PR actually solves the issue? Is it possible to write a unit test to validate the fix?

josdejong avatar Mar 05 '25 13:03 josdejong

Hi there, I am very sorry, but I am not using it anymore, so my testcase is gone. its totally ok if you close the pr.

pcace avatar Mar 06 '25 08:03 pcace

Okido, I'll close your PR. Thanks anyway for your efforts!

josdejong avatar Mar 06 '25 08:03 josdejong