mathjs icon indicating copy to clipboard operation
mathjs copied to clipboard

Typescript: MathJS does not declare constructors for expression nodes

Open davidtranhq opened this issue 3 years ago • 4 comments

The index.d.ts file does not export math.AccessorNode, math.OperatorNode, math.SymbolNode, etc. I'm wondering if this is intentional since the docs state that all nodes should be available in the math namespace.

davidtranhq avatar Aug 01 '21 20:08 davidtranhq

Hey David, This is indeed a bug in the declaration files, thank you for reporting it!

PRs are welcome :)

cshaa avatar Aug 15 '21 10:08 cshaa

@m93a needs to update the project for a long-term solution. I can do this if assign me

Madanaa avatar Aug 22 '21 06:08 Madanaa

Hey Madan, I'm not sure I understand your comment properly. Are you talking about implementing types for the nodes, or are you talking about some repository-wide TypeScript solution? If the former, feel free to open a PR! If the latter, please open a new issue with the proposal you have on your mind, we'll discuss it there.

cshaa avatar Aug 23 '21 06:08 cshaa

This will be fixed by #2290.

cshaa avatar Aug 23 '21 12:08 cshaa

As #2290 has been merged, I believe this is completed. Closing.

gwhitney avatar Oct 03 '23 03:10 gwhitney