modular_rl icon indicating copy to clipboard operation
modular_rl copied to clipboard

Line search does not check KL constraint satisfaction

Open zhihanyang2022 opened this issue 3 years ago • 2 comments

The TRPO paper (Appendix C) claims that "we use a line search to ensure improvement of the surrogate objective and satisfaction of the KL divergence constraint". However, in the current codebase, the linesearch function only checks whether the candidate update improves the surrogate advantage, which deviates from the paper and doesn't check for KL constraint.

https://github.com/joschu/modular_rl/blob/master/modular_rl/trpo.py#L92

Could you help me understand the reasoning behind this? @joschu

Thanks!

zhihanyang2022 avatar Jun 21 '21 08:06 zhihanyang2022