convert uploaded images and append images on edit

[spellik]

convert uploaded images and append images on edit

[josbeir]

Hi, looks like a nice addition! Could you fix the codesniffer issues and maybe add some tests for the parts you added?

[spellik]

Hello.

Codesniffer i will fix. Test i cant make, i dont know how to write them )

Abot forceConvert, i have opinion what it can be doing via presets with name default, what do you think?

With best regards, Oleg.

чт, 16 авг. 2018 г., 11:23 Jasper Smet [email protected]:

Hi, looks like a nice addition! Could you fix the codesniffer issues and maybe add some tests for the parts you added?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/josbeir/cakephp-image/pull/13#issuecomment-413465994, or mute the thread https://github.com/notifications/unsubscribe-auth/ABleNQyU81gAOvQBNq6TpQKaPOj1LCiZks5uRSv_gaJpZM4V-yZU .