Georgi Krastev

Results 411 comments of Georgi Krastev

A step in this direction (although not there yet): #221

I was running D2R on Mac based on this guide: https://www.outcoldman.com/en/archive/2023/06/07/playing-diablo-4-on-macos but that was before the Battle.net update. Now I'm waiting for the fix 😢 - but I don't see...

I don't think passing everything by name is close to optimal (also generating tags and traces): ```scala final def ++[E1 >: E, RIn2, ROut1 >: ROut, ROut2]( that: => ZLayer[RIn2,...

> Here is example that throws the same error: https://scastie.scala-lang.org/2Sy2v9mtQiyd0UxRR4mgAQ It compiles if I change it to: ```scala final def andEager[E1 >: E, RIn2, ROut1 >: ROut, ROut2]( that: ZLayer[RIn2,...

> The problem with this is that it used unionAll instead of union. Why is it a problem?

I would expect `++` to pick the latter. Like `++` for a `Map`. It's kinda weird if it doesn't.

If you insist on pruning, you could prune all input layers once and be done with it. No need to prune when combining.

> Based on how we currently do things, we'll have Foo2 and Bar in the combined layer, but with what you're proposing we'll end up with Foo1 and Bar How...

> We don't know that - in fact, we don't care about the order. That's the point of pruning; by keeping only the services that are statically known to be...

I just realised this compiles fine on Scala 2, so there must be some difference in the generated Scala code and/or bytecode.