sleth icon indicating copy to clipboard operation
sleth copied to clipboard

Published 20 hours ago • verified publisher icon jorisbontje

node-ethereum / vapor compatibility

Open jorisbontje opened this issue 9 years ago • 17 comments

  • [x] missing RPC method eth_accounts
  • [ ] missing RPC method eth_coinbase
  • [ ] missing RPC method eth_defaultBlock
  • [ ] missing RPC method eth_logs
  • [x] missing RPC method eth_mining
  • [ ] RPC method eth_codeAt returning Buffer instead of hexstring
  • [ ] RPC method eth_balanceAt returning empty string for 0 balance instead of 0x.
  • [x] RPC method eth_blockByNumber throws 500.
  • [x] RPC method eth_listening throws 500. https://github.com/ethereum/node-ethereum/issues/52
  • [x] RPC method eth_number not returning any result.
  • [ ] RPC methods returning hex strings lack 0x prefix
  • [ ] RPC errors throw 500 instead of returning Error object. https://github.com/ethereum/node-ethereum/issues/49
  • [ ] vapor requires all dapp assets to exist in a single html file

jorisbontje avatar Mar 07 '15 09:03 jorisbontje

whoa nice i love checklists!

wanderer avatar Mar 07 '15 19:03 wanderer

also note https://github.com/ethereum/wiki/wiki/JSON-RPC-Improvement-Proposal

wanderer avatar Mar 07 '15 20:03 wanderer

@kumavis is eth_accounts in vapor?

wanderer avatar Mar 07 '15 20:03 wanderer

listing should be fixed https://github.com/ethereum/node-ethereum/issues/52

wanderer avatar Mar 07 '15 20:03 wanderer

eth_accounts and eth_coinbase are covered in vapor. Correct behavior of the coinbase op code for the vapor backing server is not clear yet. I would imagine we'd tell the vm to use the sender's address as the coinbase whenever they send a transact or call

kumavis avatar Mar 07 '15 23:03 kumavis

oh the coinbase opcode is well defined. it just gives back the coinbase of the block that mined the tx. for eth_accounts i just stubed it out and it will just return [] incase someone tries to use it

wanderer avatar Mar 08 '15 00:03 wanderer

eth_codeAt should be fixed now

wanderer avatar Mar 08 '15 00:03 wanderer

for eth_balanceAt returning 0x is silly. is that really nessicary?

wanderer avatar Mar 08 '15 00:03 wanderer

Correct behavior of the coinbase op code for the vapor backing server is not clear yet.

I don't mean in general. Like what do dapp builders expect the opcode to mean? Dapps should not care about mining at all, so they much be using it as a proxy for something else. primary identity of user of the dapp? yeah probably. Edit: kinda confused eth.coinbase and coinbase op code there. why is it an opcode? whats the usecase?

kumavis avatar Mar 08 '15 00:03 kumavis

ok blockbynumber is returning blocks now

wanderer avatar Mar 08 '15 00:03 wanderer

@kumavis coinbase is sort of controversial opcode. but one use is using like a PRNG

wanderer avatar Mar 08 '15 00:03 wanderer

ok eth_number is returning a number

wanderer avatar Mar 08 '15 01:03 wanderer

@wanderer hmmm weird. Maybe offer a PRNG opcode that is derived from the coinbase? weird. kinda sticky situation.

kumavis avatar Mar 08 '15 01:03 kumavis

@kumavis @wanderer I don't really need coinbase actually, but I have it on my command line testing tools to verify if mining is working and which of my node(s) is doing the mining.

jorisbontje avatar Mar 08 '15 21:03 jorisbontje

ok working on methods returning hex strings lack 0x prefix

wanderer avatar Mar 09 '15 22:03 wanderer

"vapor requires all dapp assets to exist in a single html file" is of course a vapor bug -- but I anticipate putting this off for awhile to see how dapp-requesting settles

Here is the current doc on the subject, clearly in flux https://github.com/ethereum/wiki/wiki/URL-Hint-Protocol

kumavis avatar Mar 10 '15 02:03 kumavis

I've used this before to inline external assets into a single html file https://github.com/substack/html-inline

kumavis avatar Mar 10 '15 02:03 kumavis