salesforce_bulk icon indicating copy to clipboard operation
salesforce_bulk copied to clipboard

Get rid of -api in regular expression for SalesforceBulk::Connection.parse_instance()

Open mahzilla opened this issue 11 years ago • 7 comments

Salesforce used to have a -api after the instance name and no longer does.

mahzilla avatar May 17 '13 00:05 mahzilla

Same issue that I mentioned in #15. I included a monkeypatch workaround.

seanpd avatar May 18 '13 01:05 seanpd

Thanks seanpd. That also worked for me. It stopped working altogether in Production and QA last week.

JamieAyer avatar May 29 '13 20:05 JamieAyer

Just came to open a pr for the exact same fix but I see you guys beat me to it. Ping @jorgevaldivia as the gem is broken until this is fixed :(

tyro89 avatar Jun 15 '13 14:06 tyro89

At least the workaround is great. I had a broken production integration for a week.

Sent from my Windows Phone


From: Erik Selinmailto:[email protected] Sent: ý6/ý15/ý2013 10:26 AM To: jorgevaldivia/salesforce_bulkmailto:[email protected] Cc: Jamie Ayermailto:[email protected] Subject: Re: [salesforce_bulk] Get rid of -api in regular expression for SalesforceBulk::Connection.parse_instance() (#16)

Just came to open a pr for the exact same fix but I see you guys beat me to it. Ping @jorgevaldiviahttps://github.com/jorgevaldivia as the gem is broken until this is fixed :(

— Reply to this email directly or view it on GitHubhttps://github.com/jorgevaldivia/salesforce_bulk/pull/16#issuecomment-19497193.

JamieAyer avatar Jun 15 '13 15:06 JamieAyer

Any progress on this? 2 years later and the gem is still in a broken state?

kevmimcc avatar Aug 31 '15 17:08 kevmimcc

I'm pretty sure it's fixed. I do this:

gem 'salesforce_bulk', '1.0.3'

...and took out my monkeypatch workaround and everything still works.

On Mon, Aug 31, 2015 at 12:41 PM, Kevin [email protected] wrote:

Any progress on this? 2 years later and the gem is still in a broken state?

— Reply to this email directly or view it on GitHub https://github.com/jorgevaldivia/salesforce_bulk/pull/16#issuecomment-136440609 .

seanpd avatar Aug 31 '15 17:08 seanpd

I added the following to my application.rb file.

module SalesforceBulk class Connection def parse_instance() m = /https://([a-z]{2,2}[0-9]{1,2})(-api|.)/.match(@server_url) return '' unless m @instance = m[1] end end End

Jamie Ayer | Solution Architect 320 Summer Street, STE 100, Boston, MA 02210-1701 USA Xively by LogMeInhttps://xively.com/ | O. +1-781-247-2858 | M. +1-617-413-3351

[Description: C:\Users\llyons\Desktop\Xively Marketing\Branding\Logos-Habanero\xively_by_LMI-right_habanero.png]https://xively.com/

From: Sean Dempsey <[email protected]mailto:[email protected]> Reply-To: jorgevaldivia/salesforce_bulk <[email protected]mailto:[email protected]> Date: Monday, August 31, 2015 at 1:47 PM To: jorgevaldivia/salesforce_bulk <[email protected]mailto:[email protected]> Cc: Jamie Ayer <[email protected]mailto:[email protected]> Subject: Re: [salesforce_bulk] Get rid of -api in regular expression for SalesforceBulk::Connection.parse_instance() (#16)

I'm pretty sure it's fixed. I do this:

gem 'salesforce_bulk', '1.0.3'

...and took out my monkeypatch workaround and everything still works.

On Mon, Aug 31, 2015 at 12:41 PM, Kevin <[email protected]mailto:[email protected]> wrote:

Any progress on this? 2 years later and the gem is still in a broken state?

— Reply to this email directly or view it on GitHub https://github.com/jorgevaldivia/salesforce_bulk/pull/16#issuecomment-136440609 .

— Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_jorgevaldivia_salesforce-5Fbulk_pull_16-23issuecomment-2D136441826&d=AwMFaQ&c=k6LEwkJiSX1kJxtgPu1uYQ&r=TD7G2BmSQlGI8YouSwiNkCDus3pab4GbU7cfWb_OoBo&m=QigdHe3Or-mdrvlyfi4PLZ6pwbQQY0jCQohYiMSdCDQ&s=pDRPwwBfJN5e5BiHsOjoYE8RiARn8ch4-xaJtC5UA6s&e=.

JamieAyer avatar Aug 31 '15 17:08 JamieAyer