dolfinx-tutorial icon indicating copy to clipboard operation
dolfinx-tutorial copied to clipboard

Fix: Add link for Finite Element Families

Open qwinters opened this issue 1 year ago • 6 comments

Addresses FIXME comment in current documentation

(Not sure if this is the only file that needs to be edited for this change, but at least from looking at the website it seemed like this was the right spot to edit)

qwinters avatar Jul 18 '22 12:07 qwinters

@jorgensd Not sure who to put on this PR as reviewers etc. so will leave those bits to you

qwinters avatar Jul 18 '22 13:07 qwinters

This is not 100 % correct, as UFL supports elements we do not support in DOLFINx. The closest to a complete list of elements would https://docs.fenicsproject.org/basix/main/. @mscroggs Are there any elements listed in the basix link above we do not support in FFCx/DOLFINx?

jorgensd avatar Jul 18 '22 13:07 jorgensd

Hermite are supported in Basix, but do not yet work in FFCx. Otherwise all elements on the Basix list are supported in FFCx/DOLFINx. (The only other elements DOLFINx supports above these are QuadratureElements I think.)

mscroggs avatar Jul 18 '22 13:07 mscroggs

potentially useful link: https://defelement.com/lists/implementations/basix.html

mscroggs avatar Jul 18 '22 13:07 mscroggs

Thanks @jorgensd! I think you just saved me a ton of furstration / keyboard banging in the future (I thought all of ufl's would be supported b/c some old docs pointed to using a ufl.FiniteElementBase object)

@mscroggs I can update the link + added a warning for Hermite elements. Is the FFCX https://docs.fenicsproject.org/ffcx/v0.4.2/_autogenerated/ffcx.element_interface.html?highlight=quadrature#ffcx.element_interface.QuadratureElement the best link for the docs on QuadratureElements?

qwinters avatar Jul 18 '22 13:07 qwinters

@qwinters You need to also update the .py file. This should be done automatically if you have jupytext installed on your system when launching the notebook.

jorgensd avatar Aug 10 '22 09:08 jorgensd