ic-inspector icon indicating copy to clipboard operation
ic-inspector copied to clipboard

Published 20 hours ago • verified publisher icon jorgenbuilder

Local development compatibility

Open Gekctek opened this issue 11 months ago • 7 comments

Adding support for using local development canisters vs mainnet

Gekctek avatar Mar 04 '24 19:03 Gekctek

Hey @jorgenbuilder I was just dabbling with making the your extension work with localhost I figured I would throw this up here to see if you have any interest in adding it, otherwise ill just keep it in my fork

Gekctek avatar Mar 04 '24 19:03 Gekctek

Hey Ethan, this has actually been on my radar for a long time. I'm excited to review and get this merged if it's ready to go.

jorgenbuilder avatar Mar 04 '24 20:03 jorgenbuilder

It works, but im still testing it out for my canister development, so we can hold off from merging Be curious to your review insights, you know the code base best so not sure if some of my patterns fit what you are looking for

Gekctek avatar Mar 04 '24 20:03 Gekctek

How's this looking on your end? I'll wait until you give your stamp of approval before diving in, but very excited to make this happen :)

jorgenbuilder avatar Mar 06 '24 01:03 jorgenbuilder

Everything is still working on my end, so you can go ahead and take a look

Gekctek avatar Mar 06 '24 04:03 Gekctek

Had a quick look today. Not a fan of the amount of reorganization, makes the diff harder for me to follow 😅. I might attempt to pick out the functional pieces this weekend.

jorgenbuilder avatar Mar 08 '24 22:03 jorgenbuilder

That's fair. Wasn't sure how to tackle it because i had to detect the local vs not by the url (which has its own issues) and the current model initialized everything as globals no matter the context

Gekctek avatar Mar 08 '24 23:03 Gekctek