Results 18 comments of Jorge M

@ecgan, Thanks for your suggestions 🙂 , related to: >A note for the future: I think the fix here is more like a quick fix workaround. For a long term...

@ecgan, > I haven't looked detailed into the code there yet, but I have a feeling that @woocommerce/customer-effort-score has a leaky abstraction. It is nice to have a React component...

Thanks @ecgan >In your code example, we provide createNotice prop to CustomerEffortScore component, but there isn't a createNotice prop? 🤔 Source: https://github.com/woocommerce/woocommerce/blob/be15a3503837dabe74d78407810ed426f819b3ec/packages/js/customer-effort-score/src/customer-effort-score.tsx#L25-L46 Ah! It seems that createNotice prop has been...

@ecgan, @ianlin I have updated the code following the previous discussion: https://github.com/woocommerce/google-listings-and-ads/pull/1543#issuecomment-1149791189. With these changes we are: - Removing the prompt when the component is unmounted. - We are fixing...

Thanks, @eason9487 and @ecgan for your comments, >Workaround A Create another PR that branches off develop, and remove the notice in the component. Adding code snippets as below to the...

After the discussion with @mikkamp about possible solutions using WP validation schema functions such as [rest_sanitize_value_from_schema](https://developer.wordpress.org/reference/functions/rest_sanitize_value_from_schema/) and with the goal to improve the following points: 1. The sanitization of each...

Hi @Choo-lux, Thanks for reaching out! > our products change daily. Items that are deleted are not being deleted from GMC and only delete at 30 days. Products that are...

Thanks @puntope for reviewing this PR! I addressed your suggestions. > One thing I miss is the page parameter to get the results for a specific page. Not sure if...