truncato icon indicating copy to clipboard operation
truncato copied to clipboard

Truncato appears to break with Nokogiri 1.13.10

Open robert-resemble opened this issue 1 year ago • 1 comments

Hi team,

Just wanted to flag this as I did not see any issues filed yet, we're moving from nokogiri 1.13.2 to 1.13.10 and I noticed that Truncato appears to break over this update.

In specific, the returned results seem to reveal internals of Truncato gem. I haven't had a chance to investigate fully but will take a look and update this issue as I go along.

"&lt;<p>__truncato_root__&gt;<speak>H...</speak></p>"

Reproduction

irb

irb> require 'truncato'
irb> msg = "<speak>Hello, world!</speak>"
irb>Truncato.truncate(msg, max_limit: 4)
=> "&lt;<p>__truncato_root__&gt;<speak>H...</speak></p>"

robert-resemble avatar Feb 28 '23 14:02 robert-resemble

I think this is already solved here https://github.com/jorgemanrubia/truncato/issues/20 and it won't occur with latest (0.7.12) Truncato version

MichalRemis avatar Jul 03 '23 15:07 MichalRemis