hyperapp-router icon indicating copy to clipboard operation
hyperapp-router copied to clipboard

Issue 54, basic SSR without treeshaking location.state and location.actions

Open jcperez-ch opened this issue 6 years ago • 1 comments

Add a simple check for undefined to the window and history objects to avoid errors when using @hyperapp/router on the server side in combination with @hyperapp/render.

Assuming the subscribe method is only used in the client side.

https://github.com/hyperapp/router/issues/54

jcperez-ch avatar Apr 16 '18 04:04 jcperez-ch

Codecov Report

Merging #67 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #67   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines          68     69    +1     
  Branches       11     12    +1     
=====================================
+ Hits           68     69    +1
Impacted Files Coverage Δ
src/location.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8db6747...1b67687. Read the comment docs.

codecov[bot] avatar Apr 16 '18 04:04 codecov[bot]